Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional parameters are always included #13

Closed
PaulWay opened this issue Nov 8, 2018 · 1 comment
Closed

Optional parameters are always included #13

PaulWay opened this issue Nov 8, 2018 · 1 comment

Comments

@PaulWay
Copy link
Contributor

PaulWay commented Nov 8, 2018

There is no way to specify that an optional parameter is not supplied. This can change the test results.

For instance, a view `/songs/' might have an optional parameter 'genre'. If songs are found with that genre, then they are listed, otherwise all songs are listed. If no songs have the given genre, a 404 is returned. If oatts picks a random genre name, this most often results in a 404, which gives a false negative.
@PaulWay
Copy link
Contributor Author

PaulWay commented Nov 8, 2018

I've got a proof of concept solution for this at #14

@PaulWay PaulWay mentioned this issue Nov 13, 2018
Merged
JochenRousse pushed a commit to JochenRousse/oatts that referenced this issue Jul 23, 2019
Fix optional parameters for in-line example(s)
35d7c00 
This commit brings the functionality requested in issue google#13 for in-line examples.
It also adds some test cases for both in-line and custom null values.
@JochenRousse JochenRousse mentioned this issue Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulWay