Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip optional parameters where the value is null in custom values #14

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Skip optional parameters where the value is null in custom values #14

merged 1 commit into from
Feb 2, 2019

Conversation

PaulWay
Copy link
Contributor

@PaulWay PaulWay commented Nov 8, 2018

Fix #13

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@PaulWay
Copy link
Contributor Author

PaulWay commented Nov 8, 2018

I've signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@noahdietz
Copy link
Collaborator

noahdietz commented Nov 13, 2018

Thanks for the PR and apologies for the slow response.

I'm cool with this implementation. Can you add a test to the process suite for this functionality? There should be other custom value tests you can reference. Then I'll happily merge/release this.

Edit:
I updated your original PR description to include a reference to the issue you opened.

@noahdietz
Copy link
Collaborator

Hi @PaulWay will you have a chance to add a test for this? This is helpful work, would love to include it 😃

@PaulWay
Copy link
Contributor Author

PaulWay commented Jan 25, 2019

Hi @noahdietz - sorry I haven't got to this; Javascript isn't my strong suit and I don't really understand the test suite. I've got a bit of something mangled together but I really don't know what I'm doing there. Would be happy to share it with you if you can help me get it working.

@noahdietz noahdietz merged commit 955bf3d into google:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants