Fix workflow graph nodes are not centered within a group #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_712900062
branch
8 times, most recently
from
fb0f0df to
307db17
Compare
copybara-service
bot
force-pushed
the
test_712900062
branch
from
307db17 to
d3dfd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix workflow graph nodes are not centered within a group
Context: We calculate the graph height by default by calculating the topmost/bottommost node's Y coordinate (center point) and then adding half of the default node height to it (to adjust for the center point) and then adding the default paddings and margins. The error happens when the nodes are custom -> their height does not equal the default node height. To fix this, this CL modifies the topmost/bottommost point getter function to also calculate with an offset.