Fix system-test on non-POSIX paths #328
Conversation
* Properly add `tls`, `net` and `http2` node modules to the exclusion list for the `system-test` webpack build. * Replace hard-coded slashes (`/`) with either slashes or backslashes in the module exclusion rules for the `system-test` webpack build. Partially addresses googleapis#327.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 12 12
Lines 1385 1385
Branches 100 100
=======================================
Hits 1197 1197
Misses 188 188 Continue to review full report at Codecov.
|
|
@elierotenberg it looks like these changes actually landed with your other PR, has this addressed #327 at this point? |
|
Indeed, the other PR includes this commit, although it seemed relevant to create a PR with only this one. It adresses the webpack-related issues in #327, but the auth-related issues is not really solved. I doubt it will be solved at the source code level though, maybe in the CONTRIBUTING docs? |
|
@elierotenberg 👍 let's keep #327 open as a reminder to better document this. |
Properly add
tls,netandhttp2node modules to the exclusionlist for the
system-testwebpack build.Replace hard-coded slashes (
/) with either slashes or backslashesin the module exclusion rules for the
system-testwebpack build.Partially addresses #327.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #327 🦕