Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): gaxios #329

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Conversation

elierotenberg
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

As this is a straightforward PR, I didn't create a specific Issue.
This PR is ahed of #328.

* Properly add `tls`, `net` and `http2` node modules to the exclusion
  list for the `system-test` webpack build.

* Replace hard-coded slashes (`/`) with either slashes or backslashes
  in the module exclusion rules for the `system-test` webpack build.

Partially addresses googleapis#327.
* Update gaxios to latest version, enabling latest features:
  - pass default adapter to adapter option (3.1.0)
  - add initial retry delay, and set default to 100ms
@elierotenberg elierotenberg requested a review from a team as a code owner September 29, 2020 10:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          12       12           
  Lines        1385     1385           
  Branches      117      100   -17     
=======================================
  Hits         1197     1197           
  Misses        188      188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3219c11...dadff5f. Read the comment docs.

@bcoe bcoe changed the title @fix/upgrade gaxios fix(deps): gaxios Sep 30, 2020
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
@bcoe bcoe merged commit 5a15848 into googleapis:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants