test: skip public bucket system tests running under VPCSC #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
callmehiphop
approved these changes
Feb 5, 2019
There was a problem hiding this comment.
LGTM - side note I think you can programmatically skip tests in before hooks by calling this.skip() (it will skip the entire parent describe block);
before(function() {
if (RUNNING_IN_VPCSC) return this.skip();
});I think this has the added bonus of showing that the tests were intentionally skipped as opposed to them just being absent.
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under VPCSC, the process will have no egress access to
public buckets. Skipping these system tests when
GOOGLE_CLOUD_TESTS_IN_VPCSC=true environment variable is set.
This is the same variable used in the Python system-test:
https://github.com/googleapis/google-cloud-python/blob/master/storage/tests/system.py#L37