Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip public bucket system tests running under VPCSC #595

Merged
merged 4 commits into from
Feb 6, 2019
Merged

test: skip public bucket system tests running under VPCSC #595

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4538453
test: skip tests when running under VPCSC
jkwlui Feb 5, 2019
634c8a1
revert irrelevant style fix
jkwlui Feb 5, 2019
3ed1097
use mocha`s this.skip() to indicate tests is skipped purposefully
jkwlui Feb 5, 2019
61581d9
fix compile
jkwlui Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions system-test/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ import {Storage, Bucket, File, AccessControlObject, Notification, GetNotificatio
import * as nock from 'nock';
const {PubSub} = require('@google-cloud/pubsub');

// When set to true, skips all tests that is not compatible for
// running inside VPCSC.
const RUNNING_IN_VPCSC = !!process.env['GOOGLE_CLOUD_TESTS_IN_VPCSC'];

// block all attempts to chat with the metadata server (kokoro runs on GCE)
nock('http://metadata.google.internal')
.get(url => true)
Expand Down Expand Up @@ -123,6 +127,10 @@ describe('storage', () => {
});

describe('public data', () => {
before(function() {
if (RUNNING_IN_VPCSC) this.skip();
});

let bucket: Bucket;

before(() => {
Expand Down Expand Up @@ -767,6 +775,10 @@ describe('storage', () => {
});

describe('unicode validation', () => {
before(function() {
if (RUNNING_IN_VPCSC) this.skip();
});

let bucket: Bucket;

before(() => {
Expand Down