Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

django 1.10 fix #506

Closed
wants to merge 2 commits into from
Closed

django 1.10 fix #506

wants to merge 2 commits into from

Conversation

theromis
Copy link

/usr/local/lib/python2.7/dist-packages/six.py:808: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  return meta(name, bases, d)

/usr/local/lib/python2.7/dist-packages/six.py:808: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  return meta(name, bases, d)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@theromis
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@nathanielmanistaatgoogle
Copy link
Contributor

I don't know Django well enough to review this. @dhermes or @jonparrott, might either or both of you look it over?

@dhermes
Copy link
Contributor

dhermes commented May 18, 2016

@waprin Has been our go-to Django person

@nathanielmanistaatgoogle
Copy link
Contributor

Of course! @waprin, I apologize.

@waprin
Copy link
Contributor

waprin commented May 18, 2016

LGTM. This PR drops support for 1.7 in favor of the development version, which seems reasonable given that 1.7 is EOL. Created #508 to make sure we explicitly document which versions of Django we support (1.8+ after this).

@theromis I am curious if you are actually using FlowField or if the errors from it were just breaking things, because based on #494 I was planning on deleting it.

@theromis
Copy link
Author

@waprin checked for FlowField, don't see it in my code, only CredentialsField

@theacodes
Copy link
Contributor

@waprin do you feel like any tests need to be updated for this?

@waprin
Copy link
Contributor

waprin commented May 24, 2016

Yes, good point, Since we're still heavily mocking they wont' be the most useful tests but might as well keep it at 100%. @theromis let me know if you can write them, otherwise I will.

@theromis
Copy link
Author

@waprin I can write them, just give me template, from scratch is hard to do.

@waprin
Copy link
Contributor

waprin commented May 24, 2016

https://github.com/google/oauth2client/blob/master/tests/contrib/test_django_orm.py is the current tests, just add methods to TestCredentialsField and TestFlowField that calls from_db_value and verifies it deserializes correctly. We do branch coverage as well so you'll need to test the functions for both of the conditional values of the if statement. You can run the test with tox -e py27 from the root directory, check out the tox file if you want to see how it's getting run. Once it's all done, just plain tox should also pass i.e. run all the environments including python3.3 and the coverage should be 100%. Feel free to ask any more questions, or if you give up I can finish it up for you.

@theacodes
Copy link
Contributor

Closing this as it's obsoleted by #516

@theacodes theacodes closed this Jun 8, 2016
@wasabigeek
Copy link

I was trying to follow the documentation here https://developers.google.com/api-client-library/python/guide/django, but it seems like it's out of date now. Are there plans to update it?

@theacodes
Copy link
Contributor

@waprin do you want to take point on updating the docs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants