Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

django 1.10 fix #516

Merged
merged 4 commits into from
Jun 6, 2016
Merged

django 1.10 fix #516

merged 4 commits into from
Jun 6, 2016

Conversation

waprin
Copy link
Contributor

@waprin waprin commented Jun 3, 2016

@theromis hope you don't mind but I just wrote the tests for you, good call on reusing to_python. Also added to the docs that we are only supporting versions of Django that Django supports.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@@ -16,6 +16,12 @@

Utilities for using OAuth 2.0 in conjunction with
the Django datastore.

Note that only supported versions of Django are supported

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

Tell me about the scary flaming red cla: no label on this pull request?

@dhermes
Copy link
Contributor

dhermes commented Jun 6, 2016

@nathanielmanistaatgoogle It's because the Google CLA checker doesn't like PRs by committee (see the "committed with"):

screen_shot_001

@theacodes
Copy link
Contributor

Yeah it's just googlebot being obtuse. @waprin just needs to confirm things are good.

@waprin
Copy link
Contributor Author

waprin commented Jun 6, 2016

merge away

@theacodes theacodes merged commit a3cbf51 into googleapis:master Jun 6, 2016
@theacodes theacodes deleted the django_110 branch June 6, 2016 19:42
bendemaree pushed a commit to bendemaree/oauth2client that referenced this pull request Jun 7, 2016
Fix django packages for 1.10, add docs noting django 1.8+ support.
@theacodes theacodes mentioned this pull request Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants