feat: Add "transfer_manager" module for concurrent uploads and downloads as a preview feature #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
added
the
do not merge
product-auto-label
bot
added
size: l
|
Docstrings pending initial review |
andrewsg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
reviewed
Aug 22, 2022
frankyn
suggested changes
Sep 26, 2022
| return results | ||
|
|
||
|
|
||
| def download_chunks_concurrently_to_file( |
There was a problem hiding this comment.
What is the guidance on when a customer should rely on download_chunks_conccurrently_to_file directly vs. not?
There was a problem hiding this comment.
Good question! The benefit is that it adds speed for large files in cases where one thread can't saturate the network bandwidth. And the drawback is that it's much more complex, and adds overhead esp. if chunk size is low. How to distill that into customer guidance? I'll have to think about it.
cojenco
reviewed
Oct 6, 2022
|
Great to see this, starting a new project that needs exactly this functionality. Thanks. |
andrewsg
removed
the
do not merge
andrewsg
changed the title
product-auto-label
bot
added
size: xl
frankyn
approved these changes
Oct 26, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds support for concurrent uploads and downloads of multiple files, and concurrent chunked downloads of a single file.
Transfer Manager is currently a preview feature. The API and behavior of the module may change depending on user feedback. Please freely let us know about your experiences with the feature (be they problems, suggestions, or general feedback) by opening an issue on Github or commenting on an existing issue on the topic.
Fixes #36 and #388 🦕