Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "transfer_manager" module for concurrent uploads and downlo… #15

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

rsaksham
Copy link

@rsaksham rsaksham commented Nov 1, 2022

…ads as a preview feature (googleapis#844)

  • checkpoint before design doc impl

  • checkpoint

  • more tests

  • code and tests for transfer manager complete

  • proactively close temp files when finished reading

  • respond to comments; destroy tmp files as they are consumed

  • Add system tests, docstrings, address feedback

  • Respond to review comments

  • verify md5 hash of downloaded file in test

  • lint

  • default empty strings for root arguments

  • fix bug with blob constructor

  • add warning about files not being deleted if their downloads fail

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

…ads as a preview feature (#844)

* checkpoint before design doc impl

* checkpoint

* more tests

* code and tests for transfer manager complete

* proactively close temp files when finished reading

* respond to comments; destroy tmp files as they are consumed

* Add system tests, docstrings, address feedback

* Respond to review comments

* verify md5 hash of downloaded file in test

* lint

* default empty strings for root arguments

* fix bug with blob constructor

* add warning about files not being deleted if their downloads fail
@rsaksham rsaksham merged commit 50c5767 into rsaksham-dev:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants