Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go Dependencies #4177

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Bump Go Dependencies #4177

merged 7 commits into from
Jan 17, 2025

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jan 14, 2025

What?

As part of the regular release process #4162, we want to bump the golang dependencies.

Report:

Related

@inancgumus inancgumus self-assigned this Jan 14, 2025
@inancgumus inancgumus marked this pull request as ready for review January 14, 2025 17:05
@inancgumus inancgumus requested a review from a team as a code owner January 14, 2025 17:05
@inancgumus inancgumus requested review from codebien and olegbespalov and removed request for a team January 14, 2025 17:05
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @inancgumus,
it seems something is not fine on Windows, the CI is reporting a panic. Can you check it, please?

@inancgumus
Copy link
Member Author

inancgumus commented Jan 15, 2025

@codebien I'm fixing these issues in another PR first: #4184.
Update: Done ✅

@inancgumus inancgumus marked this pull request as draft January 15, 2025 16:25
@inancgumus inancgumus force-pushed the bump/golang-deps branch 3 times, most recently from 808ff65 to 7dc2269 Compare January 16, 2025 16:46
@inancgumus inancgumus marked this pull request as ready for review January 16, 2025 18:11
@inancgumus inancgumus requested a review from codebien January 16, 2025 18:11
codebien
codebien previously approved these changes Jan 17, 2025
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inancgumus 🙇

go.mod Outdated

toolchain go1.21.13
toolchain go1.23.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we agreed on that change? Shouldn't be here, something like toolchain go1.22 since we still use it CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to go1.22.10 after our internal discussion.

e3a7a1d

@inancgumus inancgumus merged commit a65267c into master Jan 17, 2025
26 of 28 checks passed
@inancgumus inancgumus deleted the bump/golang-deps branch January 17, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants