Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some browser Windows tests #4184

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix some browser Windows tests #4184

merged 4 commits into from
Jan 16, 2025

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jan 15, 2025 •
edited
Loading

What?

Fixes some tests to work on Windows.

Why?

These tests stopped working after the updates in #4177 (CI runs: 1, 2).

  • Fixes the HTTP handler slash misusage.
  • Fixes gradient differences on Windows.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@inancgumus inancgumus force-pushed the fix/browser-static-file-tests branch from 89d865e to 3dcc9db Compare January 15, 2025 16:21
@inancgumus inancgumus changed the title Fix Browser static file tests Fix some Browser Windows tests Jan 15, 2025
@inancgumus inancgumus changed the title Fix some Browser Windows tests Fix some browser Windows tests Jan 15, 2025
@inancgumus inancgumus self-assigned this Jan 15, 2025
@inancgumus inancgumus mentioned this pull request Jan 15, 2025
Merged
@inancgumus inancgumus marked this pull request as ready for review January 15, 2025 16:50
@inancgumus inancgumus requested a review from a team as a code owner January 15, 2025 16:50
@inancgumus inancgumus requested review from ankur22 and olegbespalov and removed request for a team January 15, 2025 16:50
@inancgumus inancgumus force-pushed the fix/browser-static-file-tests branch from 3dcc9db to c9b14c0 Compare January 15, 2025 17:06
ankur22
ankur22 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus merged commit 24c71da into master Jan 16, 2025
29 checks passed
@inancgumus inancgumus deleted the fix/browser-static-file-tests branch January 16, 2025 16:21
@inancgumus inancgumus mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
area: browser bug tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @ankur22 @olegbespalov