Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adding possiblity to disable schema validation for kubectl… #186

Merged
merged 1 commit into from
Jan 27, 2020
Merged

feat(cli): adding possiblity to disable schema validation for kubectl… #186

merged 1 commit into from
Jan 27, 2020

Conversation

cezkuj
Copy link
Contributor

@cezkuj cezkuj commented Jan 27, 2020

… apply

Adding --validate=false to tk apply would invoke kubectl apply with same option
Fixes #115

Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Some small nits to address, then we can pull this in 🚀

cmd/tk/workflow.go Outdated Show resolved Hide resolved
pkg/kubernetes/client/apply.go Show resolved Hide resolved
pkg/kubernetes/client/client.go Outdated Show resolved Hide resolved
@sh0rez sh0rez added component/cli Command Line Interface kind/feature Something new should be added component/kubernetes Working with Kubernetes clusters labels Jan 27, 2020
@sh0rez sh0rez self-assigned this Jan 27, 2020
… apply

Adding --validate=false to tk apply would invoke kubectl apply with same option
Fixes #115
@sh0rez sh0rez merged commit ba1a3af into grafana:master Jan 27, 2020
@sh0rez
Copy link
Member

sh0rez commented Jan 27, 2020

Cool! Thanks a lot 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cli Command Line Interface component/kubernetes Working with Kubernetes clusters kind/feature Something new should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to disable kubectl validation
2 participants