-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex tweak #2484
Regex tweak #2484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. i didn't know about that zero alloc optimization on maps
@@ -474,10 +476,10 @@ func BenchmarkBackendBlockTraceQL(b *testing.B) { | |||
|
|||
ctx := context.TODO() | |||
tenantID := "1" | |||
blockID := uuid.MustParse("149e41d2-cc4d-4f71-b355-3377eabc94c8") | |||
blockID := uuid.MustParse("2968a567-5873-4e4c-b3cb-21c106c6714b") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
booooooooooooooo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
149e41d2-cc4d-4f71-b355-3377eabc94c8
is joe's fav uuid 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. i didn't know about that zero alloc optimization on maps
Neither did I 💡 |
What this PR does:
Makes regex predicate faster. Particularly the case where there are found matches because of all the map access.
Tweak originally discussed #2410 (comment)
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]