vParquet3 documentation improvemens #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term 'dedicated columns' is still used descriptively in some cases
This helps to distinguish them from vParquet3 dedicated attribute columns Mention the OTEL semantics in the section about well-known attributes
stoewer
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
| @@ -1,20 +1,20 @@ | |||
| --- | |||
| title: Dedicated columns | |||
| description: Learn how to use dedicated columns to improve query performance. | |||
| title: Dedicated attribute columns | |||
There was a problem hiding this comment.
Good name update.
| @@ -232,12 +258,12 @@ For speed and ease-of-use, we are projecting several values to columns at the tr | |||
| * Root service/span names/StartTimeUnixNano - These are selected properties of the root span in each trace (if there is one). These are used for displaying results in the Grafana UI. These properties are computed at ingest time and stored once for efficiency, so we don't have to find the root span. | |||
| * `DurationNanos` - The total trace duration, computed at ingest time. This powers the min/max duration filtering in the current Tempo search and is more efficient than scanning the spans duration column. However, it may go away with TraceQL or we could decide to change it to span-level duration filtering too. | |||
|
|
|||
| ## Dedicated columns | |||
| ## Well-known attributes | |||
There was a problem hiding this comment.
The changes to the two names helps clarify and differentiate these capabilities. Thank you for making these changes.
knylander-grafana
approved these changes
Sep 6, 2023
Co-authored-by: Kim Nylander <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
A number of small documentation improvements related to vParquet3
Which issue(s) this PR fixes:
Fixes grafana/tempo-squad#307
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]