Speedup DistinctValue collector and exit early for ingesters #4104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
electron0zero
changed the title
joe-elliott
reviewed
Sep 20, 2024
electron0zero
commented
Sep 20, 2024
| d.values[v] = struct{}{} | ||
| d.currLen += valueLen | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| // Values returns the final list of distinct values collected and sorted. | ||
| func (d *DistinctValue[T]) Values() []T { | ||
| ss := make([]T, 0, len(d.values)) |
There was a problem hiding this comment.
@joe-elliott I think we have the same subtle bug here as well, that we had in Diff.
we are checking the len of a member var without locking. I think we got lucky here because we usualy call Values after we are done collecting.
locking this as well.
joe-elliott
approved these changes
Sep 20, 2024
joe-elliott
approved these changes
Sep 20, 2024
3 tasks
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Sep 26, 2024
…#4104) * make the collector go fast... * fixup usage and log lines * exit early when we hit the limits of collector * cleanup * CHANGELOG.md * fix lint * break with goto * locked and loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
now with early stop, we will bail out and return results instead of collecting the values after hitting the limit.
how fast? collector is 47% faster when used without any limits and 60% - 80% faster when used with limit and we hit the limits, and around 90-100% faster when we early stop when limit is hit
Benchmarks
main (no early stop) vs fast collector (with early stop)
main (with early stop) vs fast collector (with early stop)
main (no early stop) vs fast collector (no early stop)
main (with early stop) vs fast collector (no early stop)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]