-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup DistinctString and ScopedDistinctString collectors #4109
Merged
electron0zero
merged 15 commits into
grafana:main
from
electron0zero:more_fast_collectors
Oct 11, 2024
Merged
Speedup DistinctString and ScopedDistinctString collectors #4109
electron0zero
merged 15 commits into
grafana:main
from
electron0zero:more_fast_collectors
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
changed the title
drop in TODOs for what to do
Speedup DistinctString and ScopedDistinctString collectors
Sep 20, 2024
electron0zero
force-pushed
the
more_fast_collectors
branch
3 times, most recently
from
September 25, 2024 16:05
cca60c9
to
da12a0d
Compare
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
September 25, 2024 18:45
electron0zero
force-pushed
the
more_fast_collectors
branch
from
September 25, 2024 18:47
4c2f259
to
cc1c350
Compare
mapno
reviewed
Sep 26, 2024
mapno
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two nits
electron0zero
force-pushed
the
more_fast_collectors
branch
from
September 27, 2024 10:10
39b99b2
to
4239289
Compare
electron0zero
force-pushed
the
more_fast_collectors
branch
from
October 1, 2024 08:35
78321fb
to
8bc0c80
Compare
mapno
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mdisibio
approved these changes
Oct 11, 2024
electron0zero
force-pushed
the
more_fast_collectors
branch
from
October 11, 2024 18:00
2ffa89f
to
37fee58
Compare
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Oct 11, 2024
) * add local pprof files in .gitignore * fast distinct_string_collector * faster scoped_distinct_string collector * Update the usage of the combiners * add a benchmark for duplicates * Add benchmarks * Update CHANGELOG.md * return error on calls to Diff with diff disabled * return exceeded bool on Collect in ScopedDistinctString * test collect return and Exceeded * Add a note about DistinctString collector's Collect return bool * only new in withDiff versions * remove extra note * move the lock down in the Diff method * fix flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR makes the DistinctString and ScopedDistinctString collectors go faster by not tracking diff in cases where we don't use the diff
We made similar performance improvements in DistinctValue collector in #4104, and now making the similar performance improvements in the DistinctString and ScopedDistinctString collectors in this PR.
how fast?
Benchmarks:
DistinctString collector
ScopedDistinctString collector
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]