voucher-client: send User-Agent #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR already merged in #54? |
Yep, #54 targets this as a base branch so we'd have to merge this before it. I think we can consider this feature independently from #54 , as all it does is refactor the method of customization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the voucher client to send a customizable
User-Agentheader. This is easily spoofed, but helps avoucher-serverto understand the distribution of its clients.When voucher client is included as a library, the string
voucher-client/2is used. There's a method for clients to customize (e.g.my-awesome-builder/1.0).When
voucher_clientis used as a binary, the tagged version (e.g.voucher-client/2.6.2) is used.Related