client: functional opts for constructor #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Brian Chen <[email protected]>
lynnsh
reviewed
Dec 16, 2021
There was a problem hiding this comment.
I like the idea of functional options! I have a comment about NewAuthClient but otherwise it looks good.
I was also wondering if the new token client config should be in cmd/config instead, for consistency? And calling it defaultclient might be a bit misleading?
lynnsh
approved these changes
Dec 20, 2021
v2/client/idtoken.go
Outdated
| @@ -1,25 +1,22 @@ | |||
| package main | |||
| package client | |||
There was a problem hiding this comment.
A nitpick, but it might be possible to confuse Google's idtoken library used by WithIDTokenAuth with this file. Maybe it should be called default_idtoken/default_token to match it with WithDefaultTokenAuth?
thepwagner
force-pushed
the
client-functional-opts
branch
from
8a91a18 to
2e2e7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
clientpackage to preferNewClient()with functional options.This removes the need for multiple constructors (we were up to 3):
NewAuthClientis marked deprecatedNewCustomClient, which was recently introduced by Add support for ADC using voucher_client #53 , is removed.This removes the need for
SetFooBar()post-construction intializers (we were up to 2):SetBasicAuthis marked deprecatedSetUserAgent, which was recently added by voucher-client: send User-Agent #52 , is removed.The highest risk change here is to the
voucher-clientbinary, wheregetVoucherClient()is refactored to build[]client.Optionsand fall-through.Related