Restore Grails Shell + add Spring Boot CLI classes that were removed in Spring Boot 3.0.0 #13585
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
… v3.25.10 (#13501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit 9f56ca6.
This commit addresses an issue of snapshots not being published by removing the use of `GH_TOKEN` during the repository checkout process in the workflow file. The error message is "Error: fatal: could not read Username for 'https://github.com': terminal prompts disabled" when `actions/checkout@v4` does git fetch.
ci: Fix SNAPSHOT publishing problem
Temporary - Patch GROOVY_3_0_X until apache/groovy#2103 is merged
…e-old-grails-shell-project Revert "chore(core): Deprecate the old grails-shell project"
fix(deps): update spring-framework to v5.3.37
…rged" (#13580) This reverts commit 49eb631. As the problem with the Groovy build is now patched, this workaround can be removed. Related: #13578, apache/groovy#2103
# Conflicts: # .github/workflows/gradle.yml # gradle.properties
|
I'll work on the build issue tomorrow |
|
The title of the pull request is "merge6.2.x into 7.0.x " The only thing I don't really like about this is combining the merge with adding the Spring Boot CLI. There is no clean way to revert any of this. From what you posted, that looks like the CLI commands were removed in 3.4.x, but 3.4.x isn't even out yet. 7.0.x is currently based off of |
jamesfredley
changed the title
jamesfredley
changed the title
|
@codeconsole let's do a normal merge instead of squash and merge to keep the merge commit and the other 2 new commits that will allow a clean revert. At the merge commit, the build was failing, because the Spring Boot cli classes were removed in v3.0.0-M5 (github collapses the list of tags). https://github.com/grails/grails-core/pull/13585/commits |
|
Do we need all these changes/commits in 7.0.x? |
|
We could remove some of these classes, but may need them back down the road as we require the functionality, given we can no longer get them from org.springframework.boot:spring-boot-cli: as of 3.0.0. Currently grails-shell and gorm-hibernate5 need a portion of these classes. I have not dug into the other repos to see where we were using org.springframework.boot.cli.* This PR is the liberal approach. |
|
grails-wrapper was the only other reference to org.springframework.boot.cli.* |
Grails Shell
Important to resolve spring-projects/spring-boot@0555dda#diff-26fb6a79071ed389aa8e3ffe28cc8b0d171930c4e9a5277357170704e52f32c6 which is needed for gorm-hibernate5