Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

pipeline assets #1077

Closed
chadwhitacre opened this issue Jun 24, 2013 · 8 comments
Closed

pipeline assets #1077

chadwhitacre opened this issue Jun 24, 2013 · 8 comments

Comments

@chadwhitacre
Copy link
Contributor

js and css should be concatenated, minified, and served from a CDN (#866)

@chadwhitacre
Copy link
Contributor Author

@chadwhitacre
Copy link
Contributor Author

I'd like to try this with simplates at /assets/%version/gittip.css and /assets/%version/gittip.min.js that perform the concatenation and minification on the fly. @pjz had code for this in the Aspen repo somewhere.

@pjz
Copy link

pjz commented Jul 1, 2013

some code at AspenWeb/pando.py#112

@bruceadams
Copy link
Contributor

In addition to concatenating and minimizing CSS on the fly, we should scss compile the CSS on the fly as well. (I assume the compilation will only be redone when one of the relevant source files changes.)

@chadwhitacre
Copy link
Contributor Author

See also: https://github.com/gears/gears.

@chadwhitacre
Copy link
Contributor Author

CSS done in #1245. JS done in #1302.

@zbynekwinkler
Copy link
Contributor

Was the intention of this ticket to combine all css and js? Because in the current situation that is not the case (we have chosen.css, reset.css and gittip.css on each page - from what I was able to find). Shall we reopen this one or create a new one? Minimizing the number of http requests is #1 optimization.

@chadwhitacre
Copy link
Contributor Author

@zwn New ticket plz.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants