This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Prepare JavaScript for initial move to a CDN #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unused.
We're going to minimize these pretty soon anyway, but in development this will still be helpful prolly.
|
This is ready for review. |
| $gift = $(this), | ||
| $parent = $gift.parent(), | ||
| $zero = $('<button>$0</button>'), | ||
| $quarter = $('<button>25¢</button>'), |
There was a problem hiding this comment.
This unicode ¢ was clogging up the cat simplate and that made me realize that this code is no longer used post-#1070.
Conflicts: templates/base.html
We used to have the community drop-down on both /for/ and the profile page. We took it off the profile page in #1087. Now that we are including the profile.js on every page, it was clobbering the drop-down on /for/. I've moved the document.ready in profile.js (are there others?) into an init function that's only fired on profile edit. I also moved the rendering of the community listing on profiles server-side.
There was a typo, nother instead of nothers, that was doubly masked. First, if you had a team then nothers was left over from that loop. You'd expect the numbers for the communities to all be the number for the last team in that case, but we still had the js that was setting the numbers client-side, so if you had a team then everything looked fine. It was only if you didn't have a team that you saw the nother NameError.
wyze
added a commit
that referenced
this pull request
Sep 13, 2013
Prepare JavaScript for initial move to a CDN
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GITTIP_JS_SRC envvar and folds all the js into a single gittip.js asset that dynamically concatenates all of the files in ./js.