Disable min request data rate for client streaming calls #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
requested review from
JamesNK and
jtattermusch
and removed request for
JamesNK and
jtattermusch
JunTaoLuo
commented
May 21, 2019
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| <!-- static local methods are a C# 8.0 feature --> | |||
| <LangVersion>preview</LangVersion> | |||
| <NullableContextOptions>enable</NullableContextOptions> | |||
| <Nullable>enable</Nullable> | |||
There was a problem hiding this comment.
Reacting to dotnet/roslyn#35516.
JunTaoLuo
commented
May 21, 2019
| @@ -171,7 +171,7 @@ private static bool TryReadHeader(in ReadOnlySequence<byte> buffer, out bool com | |||
| } | |||
| else | |||
| { | |||
| Span<byte> headerData = stackalloc byte[HeaderSize]; | |||
| Span<byte> headerData = new byte[HeaderSize]; | |||
There was a problem hiding this comment.
Yikes dotnet/roslyn#35764. A broken Roslyn shouldn't make its way into our SDK build though, need to figure out why we are getting a bad compiler.
There was a problem hiding this comment.
The PR for the fix is already approved. Could just wait for the fix before this change goes in. and revert this workaround.
There was a problem hiding this comment.
This isn't blocking anything. Lets wait until the SDK is fixed.
JunTaoLuo
commented
May 21, 2019
| @@ -62,7 +62,7 @@ private static async Task ClientStreamingCallExample(Counter.CounterClient clien | |||
| var count = RNG.Next(5); | |||
| Console.WriteLine($"Accumulating with {count}"); | |||
| await call.RequestStream.WriteAsync(new CounterRequest { Count = count }); | |||
| await Task.Delay(1000); | |||
| await Task.Delay(2000); | |||
There was a problem hiding this comment.
Setting to 2s to trigger request data rate limit.
JunTaoLuo
requested review from
jtattermusch and
JamesNK
and removed request for
jtattermusch
JunTaoLuo
commented
May 21, 2019
src/Grpc.AspNetCore.Server/Internal/CallHandlers/ClientStreamingServerCallHandler.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
May 21, 2019
src/Grpc.AspNetCore.Server/Internal/CallHandlers/ClientStreamingServerCallHandler.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
May 21, 2019
|
I'm going to merge this because the Roslyn bug is still broken in the latest SDK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15