WIP: Quick filter all files #2521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to per_folder_sort_order
harshad1
commented
Feb 6, 2025
| @@ -284,6 +282,9 @@ protected void onFragmentFirstTimeVisible() { | |||
| public void onResume() { | |||
| loadDocument(); | |||
| _webView.onResume(); | |||
| if (_editTextUndoRedoHelper != null && _editTextUndoRedoHelper.getTextView() != _hlEditor) { | |||
| _editTextUndoRedoHelper.setTextView(_hlEditor); | |||
There was a problem hiding this comment.
We simplify loadContent and allow the undo-redo tracker to undo file load.
harshad1
commented
Feb 6, 2025
| @@ -1022,4 +1022,8 @@ public boolean onReceiveKeyPress(final int keyCode, final KeyEvent event) { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| public static class HeadlineState extends GsSearchOrCustomTextDialog.DialogState { | |||
| public final List<Integer> disabledLevels = new ArrayList<>(); | |||
There was a problem hiding this comment.
Moving action-button specific things out of the Dialog implementation
harshad1
commented
Feb 6, 2025
| @@ -1,89 +0,0 @@ | |||
| /*####################################################### | |||
There was a problem hiding this comment.
Replaced by just using GsSearchOrCustomTextDialog
harshad1
commented
Feb 6, 2025
|
|
||
| if (depth < _config.maxSearchDepth && dir.canRead()) { | ||
| handleDirectory(dir, trimLength, depth, stack); | ||
| publishProgress(stack.size(), depth, _result.size(), _countCheckedFiles); |
There was a problem hiding this comment.
Primary speedups:
- Publish progress a little less frequently
- Switch to stack vs queue, and simplify nesting
- Only get canonical file when absolutely required (this is a huge bottleneck on android)
harshad1
commented
Feb 6, 2025
| confirmDopt.messageText = title; | ||
| confirmDopt.isSearchEnabled = false; | ||
| confirmDopt.callback = (s) -> { | ||
| showConfirmDialog(activity, R.string.confirm_delete, title, null, () -> { |
There was a problem hiding this comment.
Generic confirm dialog which can be used everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new features:
Also included are a ton of fixes and improvements: