-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Quick filter all files #2521
Open
harshad1
wants to merge
31
commits into
gsantner:master
Choose a base branch
from
harshad1:quick_filter_all_files
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
34f98b9
Initial system with janky ui
harshad1 54ba2a6
Merge remote-tracking branch 'upstream/master' into per_folder_sort_o…
harshad1 a02026d
Separate options - aborting
harshad1 6f79ce0
Switching to dialog
harshad1 20b7c5e
Switching to dialog based sort
harshad1 5a01163
Cleanups to dialog
harshad1 2f6cfcb
New approach to dialog using change callback
harshad1 342d83a
Must check in the callback :)
harshad1 3237d18
Fixes, wrap improvements
harshad1 b4d1d1a
Reverted reflow settings
harshad1 b35b3d5
Fixed diff
harshad1 2f6c5c1
Better icon
harshad1 22c75b2
Getting it to work
harshad1 ebb636c
Merge branch 'master' into per_folder_sort_order
gsantner 1f82aed
Merge branch 'per_folder_sort_order' of github.com:harshad1/markor in…
harshad1 29b672c
Pulling file search changes
harshad1 b99822e
Fixing calling and references
harshad1 c7d0d7e
Maintianing state
harshad1 7298ea7
Fix for jumping to position
harshad1 9e0312f
Tweaks
harshad1 8afbca9
Tweaks to dialog state
harshad1 03be03f
Toolbar click need not be protected
harshad1 081a2ad
Proper handling of title bar
harshad1 85abee3
Fixing how files are selected
harshad1 3ec6d1e
Merge branch 'per_folder_sort_order' into quick_filter_all_files
harshad1 5c8133d
Pulled fixes and changes
harshad1 9142a2c
Merge remote-tracking branch 'upstream/master' into quick_filter_all_…
harshad1 428da2b
Fetching filename more correctly
harshad1 1413254
Fix
harshad1 3ae5467
Share to copy, long pres to open folder
harshad1 cfc2b1e
Fixes for showing
harshad1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1022,4 +1022,8 @@ public boolean onReceiveKeyPress(final int keyCode, final KeyEvent event) { | |
} | ||
return false; | ||
} | ||
|
||
public static class HeadlineState extends GsSearchOrCustomTextDialog.DialogState { | ||
public final List<Integer> disabledLevels = new ArrayList<>(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving action-button specific things out of the Dialog implementation |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We simplify loadContent and allow the undo-redo tracker to undo file load.