Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify model and prop meta #1359

Conversation

blast-hardcheese
Copy link
Member

@blast-hardcheese blast-hardcheese commented Dec 25, 2021

With a bit of doing, modelMetaType and propMetaImpl ended up being able to be unified. Both were nearly identical implementations, but stemmed from the fact that in swagger 2.0 days, model and prop were different type families. After OpenAPI unified them, this became possible.

@github-actions github-actions bot added core Pertains to guardrail-core scala-http4s Pertains to guardrail-scala-http4s labels Dec 25, 2021
@blast-hardcheese blast-hardcheese force-pushed the unify-model-and-propMeta branch from 6636266 to 0ffef29 Compare January 15, 2022 06:39
@blast-hardcheese blast-hardcheese force-pushed the unify-model-and-propMeta branch from 0ffef29 to f65e284 Compare February 8, 2022 07:10
@blast-hardcheese blast-hardcheese added the minor Bump minor version label Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1359 (f65e284) into master (5a0b5e4) will increase coverage by 13.87%.
The diff coverage is 90.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1359       +/-   ##
===========================================
+ Coverage   66.81%   80.69%   +13.87%     
===========================================
  Files          79       79               
  Lines        5446     5423       -23     
  Branches      141      138        -3     
===========================================
+ Hits         3639     4376      +737     
+ Misses       1807     1047      -760     
Impacted Files Coverage Δ
...ore/src/main/scala/dev/guardrail/SwaggerUtil.scala 79.14% <89.23%> (+1.60%) ⬆️
...a/dev/guardrail/generators/ProtocolGenerator.scala 90.30% <100.00%> (+2.71%) ⬆️
...enerators/scala/http4s/Http4sServerGenerator.scala 94.06% <100.00%> (+91.10%) ⬆️
...les/core/src/main/scala/dev/guardrail/Common.scala 98.92% <0.00%> (+2.15%) ⬆️
...re/src/main/scala/dev/guardrail/core/Tracker.scala 93.18% <0.00%> (+2.27%) ⬆️
...a/dev/guardrail/generators/LanguageParameter.scala 85.88% <0.00%> (+2.35%) ⬆️
...i/src/main/scala/dev/guardrail/cli/CLICommon.scala 61.84% <0.00%> (+2.63%) ⬆️
...ain/scala/dev/guardrail/core/extract/package.scala 94.11% <0.00%> (+5.88%) ⬆️
...rail/generators/scala/jackson/JacksonHelpers.scala 11.76% <0.00%> (+11.76%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0b5e4...f65e284. Read the comment docs.

@blast-hardcheese blast-hardcheese marked this pull request as ready for review February 8, 2022 08:01
@blast-hardcheese blast-hardcheese merged commit db42825 into guardrail-dev:master Feb 8, 2022
@blast-hardcheese blast-hardcheese deleted the unify-model-and-propMeta branch February 8, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore core Pertains to guardrail-core minor Bump minor version scala-http4s Pertains to guardrail-scala-http4s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant