-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify model and prop meta #1359
Merged
blast-hardcheese
merged 19 commits into
guardrail-dev:master
from
blast-hardcheese:unify-model-and-propMeta
Feb 8, 2022
Merged
Unify model and prop meta #1359
blast-hardcheese
merged 19 commits into
guardrail-dev:master
from
blast-hardcheese:unify-model-and-propMeta
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6636266
to
0ffef29
Compare
…ng with default after structure
…ct on generated code
0ffef29
to
f65e284
Compare
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
===========================================
+ Coverage 66.81% 80.69% +13.87%
===========================================
Files 79 79
Lines 5446 5423 -23
Branches 141 138 -3
===========================================
+ Hits 3639 4376 +737
+ Misses 1807 1047 -760
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
core
Pertains to guardrail-core
minor
Bump minor version
scala-http4s
Pertains to guardrail-scala-http4s
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a bit of doing,
modelMetaType
andpropMetaImpl
ended up being able to be unified. Both were nearly identical implementations, but stemmed from the fact that in swagger 2.0 days,model
andprop
were different type families. After OpenAPI unified them, this became possible.