StringSchema incorrectly treated as a model #1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1502
Following @djm1329's investigation,
StringSchema
was usingmodelTypeAlias
, which wasn't designed to handle primitive type aliases. This may have been a hold-over from before the object model was standardized inswagger-parser
, or perhaps it's just been a bug forever and #1407 exposed it.This'll be a
bugfix
, not aminor
, but due toearly-semver
seeming to be incompatible withdependsOn
, the only way to get the tests to run successfully currently is to useminor
to disable theearly-semver
check.