Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringSchema incorrectly treated as a model #1503

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

blast-hardcheese
Copy link
Member

@blast-hardcheese blast-hardcheese commented Jun 5, 2022

Resolves #1502

Following @djm1329's investigation, StringSchema was using modelTypeAlias, which wasn't designed to handle primitive type aliases. This may have been a hold-over from before the object model was standardized in swagger-parser, or perhaps it's just been a bug forever and #1407 exposed it.

This'll be a bugfix, not a minor, but due to early-semver seeming to be incompatible with dependsOn, the only way to get the tests to run successfully currently is to use minor to disable the early-semver check.

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #1503 (9b6a872) into master (1ea36ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          92       92           
  Lines        5561     5563    +2     
  Branches      140      140           
=======================================
+ Hits         4682     4684    +2     
  Misses        879      879           
Impacted Files Coverage Δ
...a/dev/guardrail/generators/ProtocolGenerator.scala 98.66% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea36ab...9b6a872. Read the comment docs.

Copy link

@djm1329 djm1329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blast-hardcheese blast-hardcheese added bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past and removed minor Bump minor version labels Jun 6, 2022
@blast-hardcheese blast-hardcheese merged commit 00f43bd into guardrail-dev:master Jun 6, 2022
@blast-hardcheese blast-hardcheese deleted the issue-1502 branch June 6, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behaviour for functionality that either was intended to work, or has worked in the past
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not find implicit value for parameter ev
2 participants