Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Valkey engine support for memorydb resources #40224

Merged
merged 36 commits into from
Nov 26, 2024
Merged

Add Valkey engine support for memorydb resources #40224

merged 36 commits into from
Nov 26, 2024

Conversation

atkretsch
Copy link
Contributor

@atkretsch atkretsch commented Nov 20, 2024 •
edited by ewbankkit
Loading

Description

Adding support for the engine parameter for MemoryDB clusters, including allowing valkey. Picks up where @sasidhar-aws left off with #39939.

Relations

Closes #39939.
Closes #39644.

References

AWS CreateCluster API

Output from Acceptance Testing

make testacc TESTS=TestAccMemoryDBSnapshot_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBSnapshot_basic' -timeout 360m
2024/11/20 16:11:59 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== CONT TestAccMemoryDBSnapshot_basic
--- PASS: TestAccMemoryDBSnapshot_basic (2645.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 2661.259s

make testacc TESTS=TestAccMemoryDBClusterDataSource_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBClusterDataSource_basic' -timeout 360m
2024/11/20 16:11:51 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== CONT TestAccMemoryDBClusterDataSource_basic
--- PASS: TestAccMemoryDBClusterDataSource_basic (1621.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1629.811s

make testacc TESTS=TestAccMemoryDBCluster_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_basic' -timeout 360m
2024/11/20 20:11:03 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== CONT TestAccMemoryDBCluster_basic
--- PASS: TestAccMemoryDBCluster_basic (1499.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1503.446s

make testacc TESTS=TestAccMemoryDBCluster_valkey PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_valkey' -timeout 360m
2024/11/20 16:11:47 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_valkey
=== PAUSE TestAccMemoryDBCluster_valkey
=== CONT TestAccMemoryDBCluster_valkey
--- PASS: TestAccMemoryDBCluster_valkey (1687.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1691.732s

make testacc TESTS=TestAccMemoryDBCluster_Update_engine PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_Update_engine' -timeout 360m
2024/11/20 16:11:55 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_Update_engine
=== PAUSE TestAccMemoryDBCluster_Update_engine
=== CONT TestAccMemoryDBCluster_Update_engine
--- PASS: TestAccMemoryDBCluster_Update_engine (3191.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 3203.758s

@atkretsch atkretsch requested a review from a team as a code owner November 20, 2024 22:26
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/memorydb Issues and PRs that pertain to the memorydb service. needs-triage Waiting for first response or review from a maintainer. labels Nov 20, 2024
@atkretsch atkretsch changed the title F memorydb valkey Add Valkey engine support for memorydb resources Nov 21, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2024
@ewbankkit ewbankkit self-assigned this Nov 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
@ewbankkit
r/aws_memorydb_cluster: Standardize.
b8722a1
@ewbankkit
d/aws_memorydb_cluster: Transparent tagging.
ac56917
@ewbankkit
r/aws_memorydb_parameter_group: Standardize.
96df325
@ewbankkit
d/aws_memorydb_parameter_group: Transparent tagging.
252f9ac
@ewbankkit
r/aws_memorydb_snapshot: Standardize.
ee7aed2
@ewbankkit
d/aws_memorydb_snapshot: Transparent tagging.
f232fff
@ewbankkit
r/aws_memorydb_subnet_group: Standardize.
fd1e477
@ewbankkit
d/aws_memorydb_subnet_group: Transparent tagging.
eead82a
@ewbankkit
r/aws_memorydb_user: Standardize.
81f1e20
@ewbankkit
d/aws_memorydb_user: Transparent tagging.
41e948a
@ewbankkit
Fix golangci-lint 'unparam'.
1a3875c
@ewbankkit
Fix golangci-lint 'staticcheck'.
d6b5fcc
@ewbankkit
Fix tfproviderdocs errors.
f719192
@ewbankkit
Merge branch 'main' into HEAD
58faeb7
@ewbankkit
Merge commit 'f719192ee7' into HEAD
e771346
@ewbankkit
Fix 'TestParameterChanges'.
6354ec3
@ewbankkit
Fix 'TestAccMemoryDBCluster_Update_securityGroupIds'.
3633582
@ewbankkit
Merge branch 'main' into HEAD
bb13c9c
ewbankkit
ewbankkit approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMemoryDBACL\|TestAccMemoryDBParameterGroup\|TestAccMemoryDBSubnetGroup\|TestAccMemoryDBUser' PKG=memorydb ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/memorydb/... -v -count 1 -parallel 4  -run=TestAccMemoryDBACL\|TestAccMemoryDBParameterGroup\|TestAccMemoryDBSubnetGroup\|TestAccMemoryDBUser -timeout 360m
2024/11/25 12:19:07 Initializing Terraform AWS Provider...
=== RUN   TestAccMemoryDBACLDataSource_basic
=== PAUSE TestAccMemoryDBACLDataSource_basic
=== RUN   TestAccMemoryDBACL_basic
=== PAUSE TestAccMemoryDBACL_basic
=== RUN   TestAccMemoryDBACL_disappears
=== PAUSE TestAccMemoryDBACL_disappears
=== RUN   TestAccMemoryDBACL_nameGenerated
=== PAUSE TestAccMemoryDBACL_nameGenerated
=== RUN   TestAccMemoryDBACL_namePrefix
=== PAUSE TestAccMemoryDBACL_namePrefix
=== RUN   TestAccMemoryDBACL_update_tags
=== PAUSE TestAccMemoryDBACL_update_tags
=== RUN   TestAccMemoryDBACL_update_userNames
=== PAUSE TestAccMemoryDBACL_update_userNames
=== RUN   TestAccMemoryDBParameterGroupDataSource_basic
=== PAUSE TestAccMemoryDBParameterGroupDataSource_basic
=== RUN   TestAccMemoryDBParameterGroup_basic
=== PAUSE TestAccMemoryDBParameterGroup_basic
=== RUN   TestAccMemoryDBParameterGroup_disappears
=== PAUSE TestAccMemoryDBParameterGroup_disappears
=== RUN   TestAccMemoryDBParameterGroup_update_parameters
=== PAUSE TestAccMemoryDBParameterGroup_update_parameters
=== RUN   TestAccMemoryDBParameterGroup_update_tags
=== PAUSE TestAccMemoryDBParameterGroup_update_tags
=== RUN   TestAccMemoryDBSubnetGroupDataSource_basic
=== PAUSE TestAccMemoryDBSubnetGroupDataSource_basic
=== RUN   TestAccMemoryDBSubnetGroup_basic
=== PAUSE TestAccMemoryDBSubnetGroup_basic
=== RUN   TestAccMemoryDBSubnetGroup_disappears
=== PAUSE TestAccMemoryDBSubnetGroup_disappears
=== RUN   TestAccMemoryDBSubnetGroup_nameGenerated
=== PAUSE TestAccMemoryDBSubnetGroup_nameGenerated
=== RUN   TestAccMemoryDBSubnetGroup_namePrefix
=== PAUSE TestAccMemoryDBSubnetGroup_namePrefix
=== RUN   TestAccMemoryDBSubnetGroup_update_description
=== PAUSE TestAccMemoryDBSubnetGroup_update_description
=== RUN   TestAccMemoryDBSubnetGroup_update_subnetIds
=== PAUSE TestAccMemoryDBSubnetGroup_update_subnetIds
=== RUN   TestAccMemoryDBSubnetGroup_update_tags
=== PAUSE TestAccMemoryDBSubnetGroup_update_tags
=== RUN   TestAccMemoryDBUserDataSource_basic
=== PAUSE TestAccMemoryDBUserDataSource_basic
=== RUN   TestAccMemoryDBUserDataSource_authenticationModeIAM
=== PAUSE TestAccMemoryDBUserDataSource_authenticationModeIAM
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_authenticationModeIAM
=== PAUSE TestAccMemoryDBUser_authenticationModeIAM
=== RUN   TestAccMemoryDBUser_disappears
=== PAUSE TestAccMemoryDBUser_disappears
=== RUN   TestAccMemoryDBUser_update_accessString
=== PAUSE TestAccMemoryDBUser_update_accessString
=== RUN   TestAccMemoryDBUser_update_passwords
=== PAUSE TestAccMemoryDBUser_update_passwords
=== RUN   TestAccMemoryDBUser_tags
=== PAUSE TestAccMemoryDBUser_tags
=== CONT  TestAccMemoryDBACLDataSource_basic
=== CONT  TestAccMemoryDBSubnetGroup_disappears
=== CONT  TestAccMemoryDBParameterGroupDataSource_basic
=== CONT  TestAccMemoryDBSubnetGroup_basic
--- PASS: TestAccMemoryDBParameterGroupDataSource_basic (13.60s)
=== CONT  TestAccMemoryDBSubnetGroupDataSource_basic
--- PASS: TestAccMemoryDBSubnetGroup_disappears (19.41s)
=== CONT  TestAccMemoryDBParameterGroup_update_tags
--- PASS: TestAccMemoryDBSubnetGroup_basic (21.90s)
=== CONT  TestAccMemoryDBParameterGroup_update_parameters
--- PASS: TestAccMemoryDBSubnetGroupDataSource_basic (18.82s)
=== CONT  TestAccMemoryDBParameterGroup_disappears
--- PASS: TestAccMemoryDBParameterGroup_disappears (11.86s)
=== CONT  TestAccMemoryDBParameterGroup_basic
=== CONT  TestAccMemoryDBUserDataSource_authenticationModeIAM
--- PASS: TestAccMemoryDBParameterGroup_basic (14.09s)
--- PASS: TestAccMemoryDBParameterGroup_update_tags (49.58s)
=== CONT  TestAccMemoryDBUser_tags
--- PASS: TestAccMemoryDBParameterGroup_update_parameters (73.16s)
=== CONT  TestAccMemoryDBUser_update_passwords
--- PASS: TestAccMemoryDBUserDataSource_authenticationModeIAM (55.73s)
=== CONT  TestAccMemoryDBUser_update_accessString
--- PASS: TestAccMemoryDBUser_tags (54.31s)
=== CONT  TestAccMemoryDBUser_disappears
--- PASS: TestAccMemoryDBACLDataSource_basic (178.95s)
=== CONT  TestAccMemoryDBUser_authenticationModeIAM
--- PASS: TestAccMemoryDBUser_disappears (66.21s)
=== CONT  TestAccMemoryDBUser_basic
--- PASS: TestAccMemoryDBUser_update_passwords (142.28s)
=== CONT  TestAccMemoryDBSubnetGroup_namePrefix
--- PASS: TestAccMemoryDBUser_authenticationModeIAM (58.48s)
=== CONT  TestAccMemoryDBSubnetGroup_update_description
--- PASS: TestAccMemoryDBUser_basic (48.07s)
=== CONT  TestAccMemoryDBSubnetGroup_nameGenerated
--- PASS: TestAccMemoryDBUser_update_accessString (131.58s)
=== CONT  TestAccMemoryDBACL_namePrefix
--- PASS: TestAccMemoryDBSubnetGroup_nameGenerated (17.69s)
=== CONT  TestAccMemoryDBACL_update_userNames
--- PASS: TestAccMemoryDBSubnetGroup_namePrefix (18.27s)
=== CONT  TestAccMemoryDBACL_update_tags
--- PASS: TestAccMemoryDBSubnetGroup_update_description (34.94s)
=== CONT  TestAccMemoryDBUserDataSource_basic
--- PASS: TestAccMemoryDBUserDataSource_basic (24.77s)
=== CONT  TestAccMemoryDBSubnetGroup_update_tags
--- PASS: TestAccMemoryDBACL_namePrefix (55.54s)
=== CONT  TestAccMemoryDBACL_disappears
--- PASS: TestAccMemoryDBSubnetGroup_update_tags (63.50s)
=== CONT  TestAccMemoryDBACL_nameGenerated
--- PASS: TestAccMemoryDBACL_update_tags (110.68s)
=== CONT  TestAccMemoryDBACL_basic
--- PASS: TestAccMemoryDBACL_disappears (65.48s)
=== CONT  TestAccMemoryDBSubnetGroup_update_subnetIds
--- PASS: TestAccMemoryDBSubnetGroup_update_subnetIds (53.50s)
--- PASS: TestAccMemoryDBACL_nameGenerated (65.51s)
--- PASS: TestAccMemoryDBACL_basic (180.76s)
--- PASS: TestAccMemoryDBACL_update_userNames (588.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	848.714s
% make testacc TESTARGS='-run=TestAccMemoryDBCluster\|TestAccMemoryDBSnapshot' PKG=memorydb ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/memorydb/... -v -count 1 -parallel 4  -run=TestAccMemoryDBCluster\|TestAccMemoryDBSnapshot -timeout 360m
2024/11/25 12:37:16 Initializing Terraform AWS Provider...
=== RUN   TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== RUN   TestAccMemoryDBCluster_defaults
=== PAUSE TestAccMemoryDBCluster_defaults
=== RUN   TestAccMemoryDBCluster_disappears
=== PAUSE TestAccMemoryDBCluster_disappears
=== RUN   TestAccMemoryDBCluster_nameGenerated
=== PAUSE TestAccMemoryDBCluster_nameGenerated
=== RUN   TestAccMemoryDBCluster_namePrefix
=== PAUSE TestAccMemoryDBCluster_namePrefix
=== RUN   TestAccMemoryDBCluster_create_noTLS
=== PAUSE TestAccMemoryDBCluster_create_noTLS
=== RUN   TestAccMemoryDBCluster_create_withDataTiering
=== PAUSE TestAccMemoryDBCluster_create_withDataTiering
=== RUN   TestAccMemoryDBCluster_create_withKMS
=== PAUSE TestAccMemoryDBCluster_create_withKMS
=== RUN   TestAccMemoryDBCluster_create_withPort
=== PAUSE TestAccMemoryDBCluster_create_withPort
=== RUN   TestAccMemoryDBCluster_create_fromSnapshot
=== PAUSE TestAccMemoryDBCluster_create_fromSnapshot
=== RUN   TestAccMemoryDBCluster_delete_withFinalSnapshot
=== PAUSE TestAccMemoryDBCluster_delete_withFinalSnapshot
=== RUN   TestAccMemoryDBCluster_Update_aclName
=== PAUSE TestAccMemoryDBCluster_Update_aclName
=== RUN   TestAccMemoryDBCluster_Update_description
=== PAUSE TestAccMemoryDBCluster_Update_description
=== RUN   TestAccMemoryDBCluster_Update_engine
=== PAUSE TestAccMemoryDBCluster_Update_engine
=== RUN   TestAccMemoryDBCluster_Update_maintenanceWindow
=== PAUSE TestAccMemoryDBCluster_Update_maintenanceWindow
=== RUN   TestAccMemoryDBCluster_Update_nodeType
=== PAUSE TestAccMemoryDBCluster_Update_nodeType
=== RUN   TestAccMemoryDBCluster_Update_numShards_scaleUp
=== PAUSE TestAccMemoryDBCluster_Update_numShards_scaleUp
=== RUN   TestAccMemoryDBCluster_Update_numShards_scaleDown
=== PAUSE TestAccMemoryDBCluster_Update_numShards_scaleDown
=== RUN   TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleUp
=== PAUSE TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleUp
=== RUN   TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleDown
=== PAUSE TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleDown
=== RUN   TestAccMemoryDBCluster_Update_parameterGroup
=== PAUSE TestAccMemoryDBCluster_Update_parameterGroup
=== RUN   TestAccMemoryDBCluster_Update_securityGroupIds
=== PAUSE TestAccMemoryDBCluster_Update_securityGroupIds
=== RUN   TestAccMemoryDBCluster_Update_snapshotRetentionLimit
=== PAUSE TestAccMemoryDBCluster_Update_snapshotRetentionLimit
=== RUN   TestAccMemoryDBCluster_Update_snapshotWindow
=== PAUSE TestAccMemoryDBCluster_Update_snapshotWindow
=== RUN   TestAccMemoryDBCluster_Update_snsTopicARN
=== PAUSE TestAccMemoryDBCluster_Update_snsTopicARN
=== RUN   TestAccMemoryDBCluster_tags
=== PAUSE TestAccMemoryDBCluster_tags
=== RUN   TestAccMemoryDBCluster_valkeyEngine
=== PAUSE TestAccMemoryDBCluster_valkeyEngine
=== RUN   TestAccMemoryDBSnapshotDataSource_basic
=== PAUSE TestAccMemoryDBSnapshotDataSource_basic
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN   TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN   TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN   TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN   TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN   TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT  TestAccMemoryDBClusterDataSource_basic
=== CONT  TestAccMemoryDBCluster_Update_numShards_scaleDown
=== CONT  TestAccMemoryDBCluster_valkeyEngine
=== CONT  TestAccMemoryDBCluster_Update_snapshotRetentionLimit
--- PASS: TestAccMemoryDBCluster_Update_snapshotRetentionLimit (1387.90s)
=== CONT  TestAccMemoryDBCluster_tags
--- PASS: TestAccMemoryDBCluster_valkeyEngine (1648.68s)
=== CONT  TestAccMemoryDBCluster_Update_snsTopicARN
--- PASS: TestAccMemoryDBClusterDataSource_basic (1703.41s)
=== CONT  TestAccMemoryDBCluster_Update_snapshotWindow
--- PASS: TestAccMemoryDBCluster_tags (877.17s)
=== CONT  TestAccMemoryDBSnapshot_nameGenerated
--- PASS: TestAccMemoryDBCluster_Update_snapshotWindow (1414.75s)
=== CONT  TestAccMemoryDBSnapshot_update_tags
--- PASS: TestAccMemoryDBCluster_Update_snsTopicARN (1527.34s)
=== CONT  TestAccMemoryDBSnapshot_create_withKMS
--- PASS: TestAccMemoryDBCluster_Update_numShards_scaleDown (3991.23s)
=== CONT  TestAccMemoryDBSnapshot_namePrefix
--- PASS: TestAccMemoryDBSnapshot_nameGenerated (2613.28s)
=== CONT  TestAccMemoryDBSnapshot_basic
--- PASS: TestAccMemoryDBSnapshot_create_withKMS (2485.61s)
=== CONT  TestAccMemoryDBSnapshot_disappears
--- PASS: TestAccMemoryDBSnapshot_update_tags (2564.34s)
=== CONT  TestAccMemoryDBCluster_Update_parameterGroup
--- PASS: TestAccMemoryDBSnapshot_namePrefix (2621.82s)
=== CONT  TestAccMemoryDBCluster_Update_securityGroupIds
--- PASS: TestAccMemoryDBCluster_Update_securityGroupIds (1520.45s)
=== CONT  TestAccMemoryDBCluster_Update_engine
--- PASS: TestAccMemoryDBCluster_Update_parameterGroup (1657.29s)
=== CONT  TestAccMemoryDBCluster_Update_numShards_scaleUp
--- PASS: TestAccMemoryDBSnapshot_basic (2593.85s)
=== CONT  TestAccMemoryDBCluster_Update_nodeType
--- PASS: TestAccMemoryDBSnapshot_disappears (2767.39s)
=== CONT  TestAccMemoryDBCluster_Update_maintenanceWindow
--- PASS: TestAccMemoryDBCluster_Update_engine (3143.83s)
=== CONT  TestAccMemoryDBSnapshotDataSource_basic
--- PASS: TestAccMemoryDBCluster_Update_maintenanceWindow (1420.66s)
=== CONT  TestAccMemoryDBCluster_namePrefix
--- PASS: TestAccMemoryDBCluster_Update_nodeType (2623.34s)
=== CONT  TestAccMemoryDBCluster_create_withPort
--- PASS: TestAccMemoryDBCluster_Update_numShards_scaleUp (3338.10s)
=== CONT  TestAccMemoryDBCluster_create_withKMS
--- PASS: TestAccMemoryDBCluster_namePrefix (1468.60s)
=== CONT  TestAccMemoryDBCluster_Update_description
--- PASS: TestAccMemoryDBCluster_create_withPort (1387.81s)
=== CONT  TestAccMemoryDBCluster_create_withDataTiering
--- PASS: TestAccMemoryDBCluster_create_withKMS (1388.26s)
=== CONT  TestAccMemoryDBCluster_Update_aclName
--- PASS: TestAccMemoryDBSnapshotDataSource_basic (2629.54s)
=== CONT  TestAccMemoryDBCluster_create_noTLS
--- PASS: TestAccMemoryDBCluster_Update_description (1591.66s)
=== CONT  TestAccMemoryDBCluster_delete_withFinalSnapshot
--- PASS: TestAccMemoryDBCluster_create_withDataTiering (1517.17s)
=== CONT  TestAccMemoryDBCluster_create_fromSnapshot
--- PASS: TestAccMemoryDBCluster_Update_aclName (1465.44s)
=== CONT  TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleDown
--- PASS: TestAccMemoryDBCluster_create_noTLS (1483.61s)
=== CONT  TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleUp
--- PASS: TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleDown (1850.27s)
=== CONT  TestAccMemoryDBCluster_disappears
--- PASS: TestAccMemoryDBCluster_delete_withFinalSnapshot (2887.03s)
=== CONT  TestAccMemoryDBCluster_defaults
--- PASS: TestAccMemoryDBCluster_Update_numReplicasPerShard_scaleUp (2018.82s)
=== CONT  TestAccMemoryDBCluster_nameGenerated
--- PASS: TestAccMemoryDBCluster_defaults (1371.51s)
=== CONT  TestAccMemoryDBCluster_basic
--- PASS: TestAccMemoryDBCluster_create_fromSnapshot (4208.72s)
--- PASS: TestAccMemoryDBCluster_disappears (1854.78s)
--- PASS: TestAccMemoryDBCluster_nameGenerated (1386.91s)
--- PASS: TestAccMemoryDBCluster_basic (942.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	18116.007s
% make golangci-lint PKG=memorydb
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
make: golangci-lint Checks / 3 of 3...

johnsonaj
johnsonaj approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccMemoryDBCluster_basic\|TestAccMemoryDBCluster_Update_engine\|TestAccMemoryDBCluster_valkeyEngine" PKG=memorydb

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/memorydb/... -v -count 1 -parallel 20  -run=TestAccMemoryDBCluster_basic\|TestAccMemoryDBCluster_Update_engine\|TestAccMemoryDBCluster_valkeyEngine -timeout 360m
go: downloading github.com/ProtonMail/go-crypto v1.1.3
2024/11/26 09:54:52 Initializing Terraform AWS Provider...
--- PASS: TestAccMemoryDBCluster_valkeyEngine (1643.92s)
--- PASS: TestAccMemoryDBCluster_basic (1771.44s)
--- PASS: TestAccMemoryDBCluster_Update_engine (2921.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	2927.681s

@ewbankkit ewbankkit merged commit c93f7bc into hashicorp:main Nov 26, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.78.0 milestone Nov 26, 2024
@ewbankkit
Copy link
Contributor

@atkretsch Thanks for the contribution 🎉 👏.

@atkretsch
Copy link
Contributor Author

@sasidhar-aws deserves most of the credit, I just nudged it forward a bit 😄

@atkretsch atkretsch deleted the f-memorydb_valkey branch November 26, 2024 17:20
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 26, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.78.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@magreenbaum magreenbaum mentioned this pull request Nov 27, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.78.0
Development

Successfully merging this pull request may close these issues.

Amazon MemoryDB for Valkey
4 participants
@atkretsch @ewbankkit @johnsonaj @sasidhar-aws