Add Valkey engine support for memorydb resources

[atkretsch]

Description

Adding support for the engine parameter for MemoryDB clusters, including allowing valkey. Picks up where @sasidhar-aws left off with #39939.

Relations

Closes #39939.
Closes #39644.

References

AWS CreateCluster API

Output from Acceptance Testing

make testacc TESTS=TestAccMemoryDBSnapshot_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBSnapshot_basic' -timeout 360m
2024/11/20 16:11:59 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== CONT TestAccMemoryDBSnapshot_basic
--- PASS: TestAccMemoryDBSnapshot_basic (2645.29s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 2661.259s

make testacc TESTS=TestAccMemoryDBClusterDataSource_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBClusterDataSource_basic' -timeout 360m
2024/11/20 16:11:51 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== CONT TestAccMemoryDBClusterDataSource_basic
--- PASS: TestAccMemoryDBClusterDataSource_basic (1621.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1629.811s

make testacc TESTS=TestAccMemoryDBCluster_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_basic' -timeout 360m
2024/11/20 20:11:03 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== CONT TestAccMemoryDBCluster_basic
--- PASS: TestAccMemoryDBCluster_basic (1499.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1503.446s

make testacc TESTS=TestAccMemoryDBCluster_valkey PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_valkey' -timeout 360m
2024/11/20 16:11:47 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_valkey
=== PAUSE TestAccMemoryDBCluster_valkey
=== CONT TestAccMemoryDBCluster_valkey
--- PASS: TestAccMemoryDBCluster_valkey (1687.57s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 1691.732s

make testacc TESTS=TestAccMemoryDBCluster_Update_engine PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_Update_engine' -timeout 360m
2024/11/20 16:11:55 Initializing Terraform AWS Provider...
=== RUN TestAccMemoryDBCluster_Update_engine
=== PAUSE TestAccMemoryDBCluster_Update_engine
=== CONT TestAccMemoryDBCluster_Update_engine
--- PASS: TestAccMemoryDBCluster_Update_engine (3191.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 3203.758s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.