Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Valkey engine support for memorydb resources #39939

Closed
wants to merge 5 commits into from

Conversation

sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Oct 30, 2024

Description

Adding support for the newly introduced Valkey engine in AWS MemoryDB.

Relations

Closes #39644

References

Output from Acceptance Testing

make testacc TESTS=TestAccMemoryDBSnapshot_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBSnapshot_basic'  -timeout 360m
=== RUN   TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== CONT  TestAccMemoryDBSnapshot_basic
--- PASS: TestAccMemoryDBSnapshot_basic (2894.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	2898.408s

make testacc TESTS=TestAccMemoryDBClusterDataSource_basic PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBClusterDataSource_basic'  -timeout 360m
=== RUN   TestAccMemoryDBClusterDataSource_basic
=== PAUSE TestAccMemoryDBClusterDataSource_basic
=== CONT  TestAccMemoryDBClusterDataSource_basic
--- PASS: TestAccMemoryDBClusterDataSource_basic (1996.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	2001.265s

make testacc TESTS=TestAccMemoryDBCluster_basic PKG=memorydb 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_basic'  -timeout 360m
=== RUN   TestAccMemoryDBCluster_basic
=== PAUSE TestAccMemoryDBCluster_basic
=== CONT  TestAccMemoryDBCluster_basic
--- PASS: TestAccMemoryDBCluster_basic (1975.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	1979.363s
make testacc TESTS=TestAccMemoryDBCluster_valkey PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_valkey'  -timeout 360m
=== RUN   TestAccMemoryDBCluster_valkey
=== PAUSE TestAccMemoryDBCluster_valkey
=== CONT  TestAccMemoryDBCluster_valkey
--- PASS: TestAccMemoryDBCluster_valkey (2033.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	2037.697s
make testacc TESTS=TestAccMemoryDBCluster_Update_engine PKG=memorydb
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/memorydb/... -v -count 1 -parallel 20 -run='TestAccMemoryDBCluster_Update_engine'  -timeout 360m
=== RUN   TestAccMemoryDBCluster_Update_engine
=== PAUSE TestAccMemoryDBCluster_Update_engine
=== CONT  TestAccMemoryDBCluster_Update_engine
--- PASS: TestAccMemoryDBCluster_Update_engine (3378.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	3383.847s

@sasidhar-aws sasidhar-aws requested a review from a team as a code owner October 30, 2024 02:47
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/memorydb Issues and PRs that pertain to the memorydb service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 30, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 30, 2024
@ewbankkit ewbankkit self-assigned this Oct 30, 2024
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 30, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 30, 2024
@sasidhar-aws sasidhar-aws marked this pull request as draft October 30, 2024 20:12
@sasidhar-aws
Copy link
Contributor Author

sasidhar-aws commented Oct 30, 2024

Changing status to draft, as I see update behavior is slightly different than usual. I am working on code changes.

@sasidhar-aws sasidhar-aws marked this pull request as ready for review October 31, 2024 19:33
Copy link
Contributor

@atkretsch atkretsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constants acctest.Ct1 and acctest.Ct2 have been removed.

@sasidhar-aws I'd love for this to get released as soon as possible; if you're short on time I'd be happy to make the required changes in my own fork and push a separate PR.

internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
internal/service/memorydb/cluster_test.go Outdated Show resolved Hide resolved
@sasidhar-aws
Copy link
Contributor Author

I have removed references for acctest.Ct1 and acctest.Ct2. Pushed changes in recent commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/memorydb Issues and PRs that pertain to the memorydb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon MemoryDB for Valkey
3 participants