Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set url_mask optional for network endpoint group #4227

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#11242
Replaces #4161

This argument isn't required - the gcloud command correctly creates a
serverless NEG with an API gateway resource without url_mask specified.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests (see comment).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed url_mask required mis-annotation in `google_compute_region_network_endpoint_group`, making it optional

Derived from GoogleCloudPlatform/magic-modules#5883

@modular-magician modular-magician merged commit c27e8ca into hashicorp:main Apr 15, 2022
@modular-magician modular-magician deleted the downstream-pr-cd7448e1c792b3d5fd1ef03f150698f889e69cc8 branch November 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url_mask in google_compute_region_network_endpoint_group.serverless_deployment should be optional
1 participant