Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set url_mask optional for network endpoint group #4227

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Set url_mask optional for network endpoint group #4227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/5883.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
compute: fixed url_mask required mis-annotation in `google_compute_region_network_endpoint_group`, making it optional
```
18 changes: 9 additions & 9 deletions google-beta/resource_compute_region_network_endpoint_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,6 @@ Only one of cloudRun, appEngine, cloudFunction or serverlessDeployment may be se
ForceNew: true,
Description: `The platform of the NEG backend target(s). Possible values:
API Gateway: apigateway.googleapis.com`,
},
"url_mask": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Description: `A template to parse platform-specific fields from a request URL. URL mask allows for routing to multiple resources
on the same serverless platform without having to create multiple Network Endpoint Groups and backend resources.
The fields parsed by this template are platform-specific and are as follows: API Gateway: The gateway ID,
App Engine: The service and version, Cloud Functions: The function name, Cloud Run: The service and tag`,
},
"resource": {
Type: schema.TypeString,
Expand All @@ -228,6 +219,15 @@ App Engine: The service and version, Cloud Functions: The function name, Cloud R
Description: `The user-defined name of the workload/instance. This value must be provided explicitly or in the urlMask.
The resource identified by this value is platform-specific and is as follows: API Gateway: The gateway ID, App Engine: The service name,
Cloud Functions: The function name, Cloud Run: The service name`,
},
"url_mask": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Description: `A template to parse platform-specific fields from a request URL. URL mask allows for routing to multiple resources
on the same serverless platform without having to create multiple Network Endpoint Groups and backend resources.
The fields parsed by this template are platform-specific and are as follows: API Gateway: The gateway ID,
App Engine: The service and version, Cloud Functions: The function name, Cloud Run: The service and tag`,
},
"version": {
Type: schema.TypeString,
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/compute_region_network_endpoint_group.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ The following arguments are supported:
API Gateway: Unused, App Engine: The service version, Cloud Functions: Unused, Cloud Run: The service tag

* `url_mask` -
(Required)
(Optional)
A template to parse platform-specific fields from a request URL. URL mask allows for routing to multiple resources
on the same serverless platform without having to create multiple Network Endpoint Groups and backend resources.
The fields parsed by this template are platform-specific and are as follows: API Gateway: The gateway ID,
Expand Down