Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dns_managed_zone: add zone ID attribute #4593

Merged
merged 1 commit into from
Aug 15, 2022
Merged

google_dns_managed_zone: add zone ID attribute #4593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/6406.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
dns: added `managed_zone_id` attribute to `google_dns_managed_zone` data source
```
19 changes: 14 additions & 5 deletions google-beta/data_source_dns_managed_zone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ func dataSourceDnsManagedZone() *schema.Resource {
Computed: true,
},

"managed_zone_id": {
Type: schema.TypeInt,
Computed: true,
Description: `Unique identifier for the resource; defined by the server.`,
},

"name_servers": {
Type: schema.TypeList,
Computed: true,
Expand Down Expand Up @@ -69,18 +75,21 @@ func dataSourceDnsManagedZoneRead(d *schema.ResourceData, meta interface{}) erro
return handleNotFoundError(err, d, fmt.Sprintf("dataSourceDnsManagedZone %q", name))
}

if err := d.Set("name_servers", zone.NameServers); err != nil {
return fmt.Errorf("Error setting name_servers: %s", err)
if err := d.Set("dns_name", zone.DnsName); err != nil {
return fmt.Errorf("Error setting dns_name: %s", err)
}
if err := d.Set("name", zone.Name); err != nil {
return fmt.Errorf("Error setting name: %s", err)
}
if err := d.Set("dns_name", zone.DnsName); err != nil {
return fmt.Errorf("Error setting dns_name: %s", err)
}
if err := d.Set("description", zone.Description); err != nil {
return fmt.Errorf("Error setting description: %s", err)
}
if err := d.Set("managed_zone_id", zone.Id); err != nil {
return fmt.Errorf("Error setting managed_zone_id: %s", err)
}
if err := d.Set("name_servers", zone.NameServers); err != nil {
return fmt.Errorf("Error setting name_servers: %s", err)
}
if err := d.Set("visibility", zone.Visibility); err != nil {
return fmt.Errorf("Error setting visibility: %s", err)
}
Expand Down
1 change: 0 additions & 1 deletion google-beta/data_source_dns_managed_zone_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ func TestAccDataSourceDnsManagedZone_basic(t *testing.T) {
"forwarding_config.#": {},
"force_destroy": {},
"labels.#": {},
"managed_zone_id": {},
"creation_time": {},
"reverse_lookup": {},
},
Expand Down