Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_dns_managed_zone: add zone ID attribute #4593

Conversation

modular-magician
Copy link
Collaborator

In the data source for DNS managed zones, include a new "managed_zone_id" attribute reporting the zone's ID, matching the corresponding google_dns_managed_zone resource's output attribute with the same name.

While we're here, revise the order in which we transcribe the fields from the fetched object to the data source's attributes to match the declaration order in the schema.

Supersedes hashicorp/terraform-provider-google#12301.
Relates to #6186.
Fixes hashicorp/terraform-provider-google#7128.


I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform.
  • Ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dns: added `managed_zone_id` attribute to `google_dns_managed_zone` data source

Derived from GoogleCloudPlatform/magic-modules#6406

In the data source for DNS managed zones, include a new
"managed_zone_id" attribute reporting the zone's ID, matching the
corresponding "google_dns_managed_zone" resource's output attribute
with the same name.

While we're here, revise the order in which we transcribe the fields
from the fetched object to the data source's attributes to match the
declaration order in the schema.

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 9be00bc into hashicorp:main Aug 15, 2022
@modular-magician modular-magician deleted the downstream-pr-28e0965bb48954a3715af9e54eadb94a4666ecae branch November 16, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DNS Managed Zone ID
1 participant