google_dns_managed_zone: add zone ID attribute #12301
Conversation
In the data source for DNS managed zones, include a new "managed_zone_id" attribute reporting the zone's ID, matching the corresponding "google_dns_managed_zone" resource's output attribute with the same name. While we're here, revise the order in which we transcribe the fields from the fetched object to the data source's attributes to match the declaration order in the schema.
|
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
|
Well, now I feel silly having posted this patch here, but it's not clear to me how one tells MagicModules that this "managedZoneId" field should be included in the generated Terraform data source too. |
Oh, that looks much more like what I expected to have to change. I didn't think to look around in that mmv1/third_party directory. Do you have any objection to the intention of the change? I assume that this proposed attribute's omission was unintentional. |
|
The change makes sense to me~ ! For context this was likely added by a community contributor a long time ago. The datasource could have either drifted away from the resource as it evolved or the not been completely mirrored due to the contributor specifically fulfilling their own requirements (which is okay and expected). |
|
Please see GoogleCloudPlatform/magic-modules#6406. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
In the data source for DNS managed zones, include a new "managed_zone_id" attribute reporting the zone's ID, matching the corresponding
google_dns_managed_zoneresource's output attribute with the same name.While we're here, revise the order in which we transcribe the fields from the fetched object to the data source's attributes to match the declaration order in the schema.
Fixes #7128.