Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips rendering behind dialogs #61

Open
NotHyper-474 opened this issue Feb 9, 2025 · 2 comments
Open

Tooltips rendering behind dialogs #61

NotHyper-474 opened this issue Feb 9, 2025 · 2 comments

Comments

@NotHyper-474
Copy link

NotHyper-474 commented Feb 9, 2025

HaxeUI-Flixel: Latest commit
HaxeUI-Core: Git (da27e83), also happens on latest commit
Flixel: Git (ffa691cb2d2d81de35b900a4411e4062ac84ab58) from https://github.com/FunkinCrew/flixel

Image

Bisecting points that 5845351 is the first commit where this issue occurs.
And seems like these changes in ScreenImpl is what's causing it, as reverting it solves the issue.

private override function handleSetComponentIndex(child:Component, index:Int) {
        var offset = 0;
        for (i in 0...StateHelper.currentState.length) {
            if ((StateHelper.currentState.members[i] is Component)) {
                offset = i;
                break;
            }
        }
        // ...

Although I believe this could be an issue with the project in question as I couldn't make a minimal repro.

@NotHyper-474 NotHyper-474 changed the title Tooltips rendering behind CollapsibleDialog Tooltips rendering behind dialogs Feb 10, 2025
@NotHyper-474
Copy link
Author

NotHyper-474 commented Feb 10, 2025

I think I may have found the reason why this happens, the current state (ChartEditorState) adds a bunch of things that aren't Components to its FlxTypedGroup

Details

Image

The previous code would cycle through all of them and place the tooltip at the end, but now it's placing it way before, since it's ignoring everything that isn't a component.

Details

Image

I wonder if that should be something to solve in HaxeUI-Flixel or the project.

@NotHyper-474
Copy link
Author

NotHyper-474 commented Feb 11, 2025

Managed to reproduce it on a sample project successfully.

repro.webm

Also possibly related: #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant