Prevent special characters in passwords and other args to mess up the… (

#3190)

* Prevent special characters in passwords and other args to mess up the command

This should fix #3189

* Might as well quote the pgsql driver command

Adresses issue #3189

* Debug should be false by default, fixing issue #3179

src/Bootstrap/Drupal.php

@@ -31,7 +31,7 @@ public function __construct($autoload, $root, $appRoot)
         $this->appRoot = $appRoot;
     }
 
-    public function boot($debug)
+    public function boot($debug = FALSE)
     {
         $output = new ConsoleOutput();
         $input = new ArrayInput([]);

src/Command/Database/DumpCommand.php

@@ -101,7 +101,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         if ($databaseConnection['driver'] == 'mysql') {
             $command = sprintf(
-                'mysqldump --user=%s --password=%s --host=%s --port=%s %s > %s',
+                'mysqldump --user="%s" --password="%s" --host="%s" --port="%s" "%s" > "%s"',
                 $databaseConnection['username'],
                 $databaseConnection['password'],
                 $databaseConnection['host'],
@@ -111,7 +111,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             );
         } elseif ($databaseConnection['driver'] == 'pgsql') {
             $command = sprintf(
-                'PGPASSWORD="%s" pg_dumpall -w -U %s -h %s -p %s -l %s -f %s',
+                'PGPASSWORD="%s" pg_dumpall -w -U "%s" -h "%s" -p "%s" -l "%s" -f "%s"',
                 $databaseConnection['password'],
                 $databaseConnection['username'],
                 $databaseConnection['host'],