Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: Missing argument 1 for Drupal\Console\Bootstrap\Drupal::boot() #3179

Closed
nvaken opened this issue Feb 15, 2017 · 5 comments
Closed

Warning: Missing argument 1 for Drupal\Console\Bootstrap\Drupal::boot() #3179

nvaken opened this issue Feb 15, 2017 · 5 comments

Comments

@nvaken
Copy link
Contributor

nvaken commented Feb 15, 2017

I'm seeing the following warnings in database:log:debug after a simple site:install. Also, tailing this warning are a few undefined variable notices for the $debug variable.

Warning: Missing argument 1 for Drupal\Console\Bootstrap\Drupal::boot(), called in /Users/nvaken/Develop/playgrounds/d8_5/vendor/drupal/console/src/Command/Site/InstallCommand.php on line 446 and defined in Drupal\Console\Bootstrap\Drupal->boot() (regel 34 van /Users/nvaken/Develop/playgrounds/d8_5/vendor/drupal/console/src/Bootstrap/Drupal.php) #0 /Users/nvaken/Develop/playgrounds/d8_5/web/core/includes/bootstrap.inc(548): _drupal_error_handler_real(2, 'Missing argumen...', '/Users/nvaken/D…    (0)

I think this is a bug that has been introduced in the following commit: 9e6ba52. Probably best to make the $debug parameter optional and FALSE by default in Drupal->boot()?
@nvaken nvaken changed the title Command "database:drop", is not a valid command name Warning: Missing argument 1 for Drupal\Console\Bootstrap\Drupal::boot() Feb 15, 2017
@nvaken
Copy link
Contributor Author

nvaken commented Feb 15, 2017

Wrong paste on the title, sorry 'bout that.

@jmolivas
Copy link
Member

@nvaken yes debug parameter must be set to false as default at the method

nvaken pushed a commit to nvaken/drupal-console that referenced this issue Feb 21, 2017
Debug should be false by default, fixing issue hechoendrupal#3179
645999b
@nvaken nvaken mentioned this issue Feb 21, 2017
Merged
@nvaken
Copy link
Contributor Author

nvaken commented Feb 21, 2017

@jmolivas See above PR.

jmolivas pushed a commit that referenced this issue Feb 23, 2017
@nvaken @jmolivas
Prevent special characters in passwords and other args to mess up the… (
86df4f8 
#3190)

* Prevent special characters in passwords and other args to mess up the command

This should fix #3189

* Might as well quote the pgsql driver command

Adresses issue #3189

* Debug should be false by default, fixing issue #3179
@neclimdul
Copy link
Contributor

Any chance of this fix getting fast tracked into a release? This isn't a warning in php 7.1 but actually a fatal error making those commands completely broken.

http://php.net/manual/en/migration71.incompatible.php

michaellenahan pushed a commit to michaellenahan/drupal-console that referenced this issue Mar 16, 2017
Fix contents of generated sites.php file (hechoendrupal#3179)
f0871a8
@jmolivas
Copy link
Member

jmolivas commented Jun 7, 2017

Closing this one. Feel free to comment if still happening after updating to the latest version.

@jmolivas jmolivas closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neclimdul @jmolivas @nvaken