Update to Symfony 3. #2988
Merged
Update to Symfony 3. #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
reviewed
Dec 6, 2016
| "symfony/dom-crawler": "~2.8|~3.0", | ||
| "symfony/http-foundation": "~2.8", | ||
| "symfony/css-selector": "~2.7|~3.1", | ||
| "symfony/debug": "~2.6|~3.1", |
There was a problem hiding this comment.
If Drupal Console was working before with 2.8 versions then I would still keep this mentioned. This can only help in resolving a workable set of dependencies for specific projects. You never know they might have a dependency on css-selector ~2.8 somewhere.
So I suggest to simply mention all supported versions, for example:
"symfony/css-selector": "~2.7|~2.8|~3.0|~3.1",
|
@pfrenssen true I will update this dependency |
|
Thanks! Make sure to check all of them, the css-selector one was just an example. |
bpresles
pushed a commit
to bpresles/DrupalConsole
that referenced
this pull request
Dec 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.