Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Symfony 3. #2988

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Update to Symfony 3. #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@
"alchemy/zippy": "0.3.5",
"composer/installers": "~1.0",
"drupal/console-core" : "~1.0",
"symfony/css-selector": "~2.7|~2.8",
"symfony/debug": "~2.6|~2.8",
"symfony/dom-crawler": "~2.8|~3.0",
"symfony/http-foundation": "~2.8",
"symfony/css-selector": "~2.7|~3.1",
"symfony/debug": "~2.6|~3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Drupal Console was working before with 2.8 versions then I would still keep this mentioned. This can only help in resolving a workable set of dependencies for specific projects. You never know they might have a dependency on css-selector ~2.8 somewhere.

So I suggest to simply mention all supported versions, for example:

"symfony/css-selector": "~2.7|~2.8|~3.0|~3.1",

"symfony/dom-crawler": "~2.8|~3.1",
"symfony/http-foundation": "~2.8|~3.1",
"guzzlehttp/guzzle": "~6.1",
"gabordemooij/redbean": "~4.3",
"doctrine/annotations": "1.2.*",
"dflydev/placeholder-resolver": "~1.0",
"symfony/expression-language": "^2.8"
"symfony/expression-language": "~2.8|~3.1"
},
"bin": ["bin/drupal"],
"config": {
Expand Down
Loading