-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only recheck shrunken input #336
Only recheck shrunken input #336
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
661c169
to
c969c98
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
78fbbbc
to
5597f92
Compare
This comment has been minimized.
This comment has been minimized.
Yep @adam-becker. I did that so that I could submit issue Zaid-Ajaj/Fable.Mocha#38. @ThisFunctionalTom, I think that is why the Fable test is failing. My assertion depends on the contents of the error message but Mocha isn't including the same information as Expecto in the error message. |
5597f92
to
a266065
Compare
@adam-becker, I just force pushed the dropping of that The easies workaround is to drop that second assertion. If I took that approach, then I would only drop it for Fable. This issue with Mocha isn't preventing me from making progress on this feature at the moment (other than the small amount of time today to investigate the problem), so I will ignore it for a while as I continue working on this feature. |
This comment has been minimized.
This comment has been minimized.
f2b0b5e
to
a2ad201
Compare
f025a59
to
9fe84de
Compare
This PR is now ready for review. It needs some clean up at least in |
c7bfc93
to
3ea9bb5
Compare
Force pushed after rebasing on |
812b186
to
896c439
Compare
34c6b49
to
cc125c0
Compare
0c02671
to
3e1de60
Compare
I am happy with everything now. I squashed the commits I recently pushed into their respective places. Then I reviewed all changes via GitHub and ran tests locally on every commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3e1de60
to
b39906d
Compare
Resolves #332
...at least that is my plan. It is not there yet. So far, this branch adds
Lazy<>
to the definition ofProperty<>
. I think that is the right first step to being able to avoid executing the test on non-shrunken inputs.@dharmaturtle, can you help me with this? I got the Hedgehog project to compile. Can you make all projects compile?