Add BindReturn to Property CE #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TysonMN
force-pushed
the
add_BindReturn
branch
from
15e5e6c
to
baa0c93
Compare
TysonMN
force-pushed
the
add_BindReturn
branch
from
baa0c93
to
136f3c3
Compare
This comment has been minimized.
This comment has been minimized.
TysonMN
force-pushed
the
add_BindReturn
branch
from
136f3c3
to
e57d545
Compare
|
Separate from this PR, I merged in the code that adds and then uses |
TysonMN
force-pushed
the
add_BindReturn
branch
5 times, most recently
from
81a6ac4
to
31eb928
Compare
There was a problem hiding this comment.
Ah, I'm a bit late, but I think failOnFalse should've been named failureWhenFalse for two reasons:
- It's called
Failurein Hedgehog. failwithexists. My mind conflatesfailOnFalsewith that, so seeingproperty { ... } |> Property.failOnFalse |> Property.checkis slightly surprising.failis (mostly) a verb, whilefailureis (mostly) a noun.
Oh well.
Did you intentionally not use checkBool on your tests?
Otherwise LGTM!
|
I agree that |
TysonMN
force-pushed
the
add_BindReturn
branch
3 times, most recently
from
ac40743
to
ea75302
Compare
TysonMN
force-pushed
the
add_BindReturn
branch
2 times, most recently
from
8459fba
to
a63f90c
Compare
TysonMN
force-pushed
the
add_BindReturn
branch
from
a63f90c
to
ee95ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is makes progress on issue #332. This PR should be merged before PR #336 (which is still only a draft). After this PR is merged, I will force push an update to the branch in that PR that includes a rebase on top of the branch in this PR.
The main point of this PR is to add
BindReturnto thePropertycomputational expression. As the corresponding RFC saysThat is preciously what we need to avoid testing non-shrunken inputs during rechecking.
One "controversial" thing this PR does is remove the
Return(bool)method from thePropertyCE. I removed it because having both this method andBindReturnwere giving me compiler errors. RemovingReturn(bool)was the only solution that I found. Maybe there is another one we could use instead. However,Return(bool)is not necessary. It is syntactic sugar that allows the user to omit putting|> Property.failOnFalseafter their CE instance. Therefore, I think it is reasonable to remove this.