Applicative Gen.apply #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of this PR reverts the runtime optimization added in PR #239 because correct applicative behavior is more important (since it can lead to smaller shrunken values). |
TysonMN
force-pushed
the
applicative_Gen.apply
branch
2 times, most recently
from
1f30d6f
to
4cedc26
Compare
TysonMN
force-pushed
the
applicative_Gen.apply
branch
from
4cedc26
to
f5eec9a
Compare
|
I force pushed a new stack of commits. They are essentially the same, but some things should now be clearer. The main improvement is the addition of a commit that adds a characterization test for |
dharmaturtle
approved these changes
Dec 29, 2021
TysonMN
force-pushed
the
applicative_Gen.apply
branch
2 times, most recently
from
325795f
to
22cd73f
Compare
TysonMN
force-pushed
the
applicative_Gen.apply
branch
from
98be63e
to
02acb1f
Compare
|
I squashed the two changes based on your comments into the "correct" commits and force pushed |
This was referenced Dec 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397
...at least that is the plan. Currently this is a draft PR. The behavior is not correct yet. There is a failing test.