Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Journal bug in Property.BindReturn #401

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Fix Journal bug in Property.BindReturn #401

merged 2 commits into from
Dec 31, 2021

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Dec 30, 2021

This PR is stacked on top of PR #399, which is stacked on top of PR #398. Those PRs should be completed first.

@TysonMN TysonMN force-pushed the BindReturn_Journal branch 4 times, most recently from be69384 to c505526 Compare December 30, 2021 15:47
@TysonMN TysonMN mentioned this pull request Dec 30, 2021
Merged
dharmaturtle
dharmaturtle approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have thoughts about the name printValue but whatever lol

@TysonMN
Copy link
Member Author

TysonMN commented Dec 30, 2021

Sure, but printValue is an existing and non-public function, so not a big deal.

@TysonMN TysonMN merged commit 15f2524 into hedgehogqa:master Dec 31, 2021
@TysonMN TysonMN deleted the BindReturn_Journal branch December 31, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmaturtle dharmaturtle dharmaturtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TysonMN @dharmaturtle