aghstrings: mk cloning correct

internal/aghstrings/strings.go

@@ -5,18 +5,18 @@ import (
 	"strings"
 )
 
-// CloneSlice returns the exact copy of a.
-func CloneSlice(a []string) (b []string) {
-	return append(b, a...)
-}
-
 // CloneSliceOrEmpty returns the copy of a or empty strings slice if a is nil.
 func CloneSliceOrEmpty(a []string) (b []string) {
-	if len(a) == 0 {
-		return []string{}
+	return append([]string{}, a...)
+}
+
+// CloneSlice returns the exact copy of a.
+func CloneSlice(a []string) (b []string) {
+	if a == nil {
+		return nil
 	}
 
-	return CloneSlice(a)
+	return CloneSliceOrEmpty(a)
 }
 
 // InSlice checks if string is in the slice of strings.

internal/aghstrings/strings_test.go

@@ -20,7 +20,7 @@ func TestCloneSlice_family(t *testing.T) {
 	})
 
 	t.Run("cloneslice_empty", func(t *testing.T) {
-		assert.Nil(t, CloneSlice([]string{}))
+		assert.Equal(t, []string{}, CloneSlice([]string{}))
 	})
 
 	t.Run("clonesliceorempty_nil", func(t *testing.T) {