Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editable installs #12838

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 31, 2022

Proposed change

Followup to #12770
While moving the project metadata from setup.cfg to pyproject.toml, I missed that setuptools doesn't yet support editable installs with only pyproject.toml. It requires a dummy setup.py or setup.cfg file. pypa/setuptools#2816

This isn't an issue for core since the setup.cfg wasn't empty and thus still exists.
I'll add a comment there too, however. Just to be safe.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 62d0882 into home-assistant:dev Jun 29, 2022
@cdce8p cdce8p deleted the editable-installs branch June 29, 2022 04:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants