Update iOS JavaScript shim #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…corporate-stimulus branch
|
I'm not sure what the test failure is here with CI. The tests succeed when I run them locally. |
|
@jayohms Is this PR still relevant? |
|
@svara @dginsburg Yep this PR is still necessary, but it's a breaking change from what we use in the HEY web app. So, we can't merge or include this in new versions until we shim these changes and roll them out to HEY production. I've got a HEY PR ready, but it probably won't ship for a couple weeks. @dginsburg We'll be open sourcing the libraries next month and I'm giving a Strada talk at Rails World in October 🙌 |
* main: (66 commits) Expose, by making `didReceive(message:)` and all of component's view lifecycle functions public. This allows to use them for testing. Add example component tests. Define `BridgingDelegate` to enable component testing by mocking the component's delegate. Add reply(with:) function to `BridgeDelegate` to avoid accessing the bridge directly from within the BridgeComponent. Expose `Message` and `Message.Metadata`'s initializers. Bump min iOS version in package to iOS 14. Refactor logging using the logger with appropriate log levels. Add `debugLoggingEnabled` flag to config. Define enabled and disabled loggers. Move user agent substring generation from `Bridge` to `Strada`. Move json encoder/decoder configurations to a config inside a Strada namespace. Tweak `Message` file structure. Rename Message's functions related to Encodable types. Rename reply(to:) functions. Rename Message's decodedJsonData() to decodedDataObject(). Tweak Message's replacing with an encodable object function. Add tests for replyTo with a Codable. Add option to reply with a Encodable type. Improve decoder related `Message` tests. Add `BridgeComponent` tests. Add option to reply to an event. ... # Conflicts: # Source/strada.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to the iOS JS code to match the changes from hotwired/strada-web#2