Update Strada to incorporate Stimulus and changes from HEY #2
Conversation
| @@ -10,6 +10,7 @@ const options = { | |||
| bundle: true, | |||
| minify: true, | |||
| banner: banner, | |||
| format: 'esm', | |||
There was a problem hiding this comment.
We ran into what I believe is a dependency conflict because Strada embeds Stimulus and we also include the public Stimulus package. Changing the output format to esm caused the compiled JS to only export the Component object and eliminated the conflict.
I saw that Hotwire has moved to a new build system so I didn't spend a lot of time fighting it as I expect this will be redone for public release.
|
Lovely, @dginsburg! I should be able to look at this next week. |
There was a problem hiding this comment.
@dginsburg This is embarrassingly late, but I really appreciate all the changes in this PR — they're extremely helpful 🙏. There are still a few HEY-specific concerns in the BridgeElement class, but I'll work on removing those in separate, future PRs.
I'm finally on the push to properly open source Strada. I've got the strada-android library API changes complete and I'll move onto strada-ios after I'm done with the web library changes.
This PR continues the work begun by Zach Waugh to make Stimulus a dependency and export the
Componentspecialization of the StimulusController.Most of the work was functional as we received it. We cleaned up some minor things and compared it to the Strada code that can be pulled from hey.com. We added the additional functionality that was on hey.com for Android compatibility.
I'm not sure what held up the completion of Strada in Dec 2020. My guess would be that
BridgeElementcontains attributes and CSS classes that are HEY patterns.Strada is useful in its current form and we have it on our production site at Polywork.
There is a corresponding iOS PR at hotwired/strada-ios#2.