Attemp to fix Kingdom Heart , Valkyrie Profile & Tales Of Phantasia #3767
Conversation
|
@solarmystic , may need some help from you to test this in your inventory :) |
| @@ -989,14 +989,14 @@ void TextureCache::SetTextureFramebuffer(TexCacheEntry *entry) | |||
| if (useBufferedRendering) { | |||
| // For now, let's not bind FBOs that we know are off (invalidHint will be -1.) | |||
| // But let's still not use random memory. | |||
| if (entry->framebuffer->fbo && entry->invalidHint != -1) { | |||
| if (!entry->framebuffer->fbo && entry->invalidHint == -1) { | |||
There was a problem hiding this comment.
In other words you're changing this to an ||, does that mean you're removing the invalidHint check?
-[Unknown]
There was a problem hiding this comment.
Yep , to remove the invalidHint check or would be simply
if (entry->framebuffer->fbo) {
There was a problem hiding this comment.
I put it back in a simple way which is to skip the invalidHint check so as to bind to all fbo . This makes Valkyrie Profile show the logo/title screen correctly .
|
When this commit in place , the enlarge framebuffer routine will be fine at the same time for Black Rock Shooter as well as the Kingdom Heart Shadow since the generated drawing size is wrong previously. |
|
Test results based on your alterations compared to latest master (0.9.1-832):- Major observations:-
@raven02 You also mention that the embiggening framebuffer routine won't affect BRS and KH negatively after you apply this commit? Interesting, but one step at a time though, let's get this through first. |
|
Yep, agree. I will pull out that enlarge framebuffer one after this gone through ok. |
|
Feel free to merge if it is okay .I should be no more add into this commit. |
|
Since i just got around the title/in-game issue in Tales Of Phantasia and i don't have anymore addon to the framebuffer stuff , may be just a single go here for one merge . In summay, @solarmystic , feel free to test it out for final merge. |
|
Have you rebased it on the latest master yet? Confirm that, and I will test out this combined commit. |
|
I think you can get the changes and apply to master and test it out . I just done the same to test it on tales of phantansia and get the Screenshots above |
|
Thanks a lot . I'm off now. Feel free to merge it BTW , this also fixes some scenes in Shadow of Destiny as well . |
|
i tried it on new version of ppsspp 0.91 926 it still shadow issues of kingdom hearts birth by sleep today i found a bug of cutscene on buffered rendering is flicklring so much there shadow issues same is jpcsp i got it from last year on my computer |
|
That's because this pull request hasn't been merged yet. The version you're using (0.9.1-926) does not have the fixes implemented yet. Have some patience. |
|
@asbel123: You realize this hasn't been submitted yet, right? Or do you mean you compiled your own build? |
Attemp to fix Kingdom Heart , Valkyrie Profile & Tales Of Phantasia
In summay,